Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ./assets/dir-index-html submodule #8532

Closed
lidel opened this issue Oct 29, 2021 · 2 comments · Fixed by #8555
Closed

Remove ./assets/dir-index-html submodule #8532

lidel opened this issue Oct 29, 2021 · 2 comments · Fixed by #8555
Assignees
Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo topic/bootcamp Issues that could be useful in bootcamp process

Comments

@lidel
Copy link
Member

lidel commented Oct 29, 2021

I believe we should merge dir-index-html back to go-ipfs.

No reason for it to be outside. It is a key part of gateway functionality, and having a separate repo + git submodule makes it ridiculously hard to contribute changes.

@lidel lidel added kind/maintenance Work required to avoid breaking changes or harm to project's status quo topic/bootcamp Issues that could be useful in bootcamp process labels Oct 29, 2021
@longfeiWan9
Copy link
Contributor

@lidel li maybe I can try to work on this as part of BootCamp?

@lidel
Copy link
Member Author

lidel commented Nov 17, 2021

@longfeiWan9 sounds good!

Some pointers:

  • would be really nice if we could preserve git history while replacing ./assets/dir-index-html submodule with a plain subdirectory, to keep contributor info intact
  • (optional research) after move is done, you could see if we still need the bindata build step in ./assets:
    • afaik BindataVersionHash is used only here in the Etag HTTP header to indicate to the browser when HTML with directory listing changed
    • we also use bindata to generate something for ./assets/ init-doc but i'm lacking context why (no need to change anything, just curious myself :))

ps. i'm around if you want to chat about it (calendly link is in my slack profile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Work required to avoid breaking changes or harm to project's status quo topic/bootcamp Issues that could be useful in bootcamp process
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants