Choose Key type at initialization #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willscott
commented
Apr 29, 2020
willscott
commented
- should be rebased over a released go-ipfs-config version
- Add a command for 'rolling over' identity
Stebalien
reviewed
May 1, 2020
willscott
force-pushed
the
feat/ed25519identity
branch
from
8ee5261
to
2d2cc12
Compare
aschmahmann
force-pushed
the
feat/ed25519identity
branch
from
33f5df5
to
4eaec06
Compare
aschmahmann
added
the
status/blocked
|
This PR seems to be blocked for now by js-ipfs support for Ed25519 IPNS Keys (e.g. libp2p/js-libp2p-crypto#145) as we'd prefer not to roll the defaults to something that'll be problematic for js-ipfs. This shouldn't be blocked for too long, but if it is we can revisit. |
aschmahmann
force-pushed
the
feat/ed25519identity
branch
from
4eaec06
to
607f2a9
Compare
petar
force-pushed
the
feat/ed25519identity
branch
from
59ee134
to
6780ee4
Compare
aschmahmann
requested changes
Jul 13, 2020
aschmahmann
reviewed
Jul 14, 2020
There was a problem hiding this comment.
Seems good to go once we merge + bubble ipfs/go-ipfs-config#105
aschmahmann
changed the title
* add support for choosing a peer key type (e.g. RSA or Ed25519) when initializing the repo * test all variants of ipfs init: RSA, Ed25519 and default * update subdomain gateway sharness test to publish IPNS using RSA and Ed25519 keys * use default identity bit lengths defined in config repo instead of having separate defaults in go-ipfs * update config repo dependency Co-authored-by: Will Scott <will@cypherpunk.email> Co-authored-by: Petar Maymounkov <petarm@gmail.com>
aschmahmann
force-pushed
the
feat/ed25519identity
branch
from
cf81c2b
to
4674f77
Compare
aschmahmann
removed
the
status/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.