Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

error if bit size specified with ed25519 keys #105

Merged
merged 3 commits into from
Jul 14, 2020
Merged

error if bit size specified with ed25519 keys #105

merged 3 commits into from
Jul 14, 2020

Conversation

petar
Copy link
Contributor

@petar petar commented Jul 13, 2020

No description provided.

@petar petar requested a review from aschmahmann July 13, 2020 20:43
@welcome
Copy link

welcome bot commented Jul 13, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann aschmahmann changed the title error if bit size specifiede with ed25519 keys error if bit size specified with ed25519 keys Jul 14, 2020
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, let's just add a Go test to init_test.go checking for failure here and then merge it.

@petar petar merged commit 0b25905 into master Jul 14, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants