All changes to date including pause requests & start paused, along with new adds for cleanups and checking of execution #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow graphsync requests to be paused and unpaused via request cancelling and DoNotSendCIDs extension
remove extraneous allocation of closure functions
allow pausing requests imperatively via PauseRequest function
add the ability for a hook to pause a response right when it's first received
provide a mechanism for responders to learn a requestor cancelled a request and for requestors to learn a request was cancelled
process the responder returning a request cancelled error code and also support sentinel errors
remove loader, also only fire restart request as needed
Fix external pauses missing a block
Run complete listener in same thread as response processing, making it less susceptable to interruption via cancel
fix checking for context cancellation errors based off of the way ipld-prime does not wrap errors
make cancels only get recorded if actual blocks are not sent -- otherwise the request is considered complete -- and the complete hook always runs
Handler the case where a pause is requested but never actually takes place
Properly handle cancels for both paused and unpaused states
make sure that the traverser is finished in the request executor
hannahhoward
force-pushed
the
feat/refactor-executor
branch
from
0195740
to
d592717
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Emit events with received cids (#71) * persist received cids on channel state. * Send, Receive and Validate Restart requests (#75) * Send, Receive and Validate Requests * Initiating and Responding Tests and bug fixes (#76) * Testing for resuming data transfer work * Cleanup Push Restarts PR (#79) * cleanup of restart PR * link the peers * Tests for pull restarts (#84) * tests for pull restarts * Merge Tests cleanup work (#92) * cleanup of restart PR * cleanup timedout channels (#93) * backward compatibility of restart (#96) * backward compatibility of restart * changes and tests * more tests * better error handling for restarts * feat(message): switch to cbor map encoding (#97) switch to cbor map encoding for the 1_1 message protocol * feat(channels): setup datastore migrations (#99) setup datatransfer channels so they migrate over successfully Co-authored-by: Hannah Howard <hannah@hannahhoward.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.