Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(responsemanager): remove unused maxInProcessRequests parameter #319

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix(responsemanager): remove unused maxInProcessRequests parameter #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion impl/graphsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ func New(parent context.Context, network gsnet.GraphSyncNetwork,
requestorCancelledListeners,
blockSentListeners,
networkErrorListeners,
gsConfig.maxInProgressIncomingRequests,
network.ConnectionManager(),
gsConfig.maxLinksPerIncomingRequest,
responseQueue)
Expand Down
3 changes: 0 additions & 3 deletions responsemanager/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ type ResponseManager struct {
networkErrorListeners NetworkErrorListeners
messages chan responseManagerMessage
inProgressResponses map[responseKey]*inProgressResponseStatus
maxInProcessRequests uint64
connManager network.ConnManager
// maximum number of links to traverse per request. A value of zero = infinity, or no limit
maxLinksPerRequest uint64
Expand All @@ -129,7 +128,6 @@ func New(ctx context.Context,
cancelledListeners CancelledListeners,
blockSentListeners BlockSentListeners,
networkErrorListeners NetworkErrorListeners,
maxInProcessRequests uint64,
connManager network.ConnManager,
maxLinksPerRequest uint64,
responseQueue taskqueue.TaskQueue,
Expand All @@ -150,7 +148,6 @@ func New(ctx context.Context,
networkErrorListeners: networkErrorListeners,
messages: messages,
inProgressResponses: make(map[responseKey]*inProgressResponseStatus),
maxInProcessRequests: maxInProcessRequests,
connManager: connManager,
maxLinksPerRequest: maxLinksPerRequest,
responseQueue: responseQueue,
Expand Down
6 changes: 3 additions & 3 deletions responsemanager/responsemanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,22 +1137,22 @@ func newTestData(t *testing.T) testData {
}

func (td *testData) newResponseManager() *ResponseManager {
rm := New(td.ctx, td.persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, 6, td.connManager, 0, td.taskqueue)
rm := New(td.ctx, td.persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, td.connManager, 0, td.taskqueue)
queryExecutor := td.newQueryExecutor(rm)
td.taskqueue.Startup(6, queryExecutor)
return rm
}

func (td *testData) nullTaskQueueResponseManager() *ResponseManager {
ntq := nullTaskQueue{tasksQueued: make(map[peer.ID][]peertask.Topic)}
rm := New(td.ctx, td.persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, 6, td.connManager, 0, ntq)
rm := New(td.ctx, td.persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, td.connManager, 0, ntq)
return rm
}

func (td *testData) alternateLoaderResponseManager() *ResponseManager {
obs := make(map[ipld.Link][]byte)
persistence := testutil.NewTestStore(obs)
rm := New(td.ctx, persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, 6, td.connManager, 0, td.taskqueue)
rm := New(td.ctx, persistence, td.responseAssembler, td.requestQueuedHooks, td.requestHooks, td.updateHooks, td.completedListeners, td.cancelledListeners, td.blockSentListeners, td.networkErrorListeners, td.connManager, 0, td.taskqueue)
queryExecutor := td.newQueryExecutor(rm)
td.taskqueue.Startup(6, queryExecutor)
return rm
Expand Down