Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Split client and server #570

Merged
merged 7 commits into from
Aug 13, 2022
Merged

Split client and server #570

merged 7 commits into from
Aug 13, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jul 5, 2022

WIP

Closes #568

@Jorropo Jorropo self-assigned this Jul 5, 2022
@Jorropo Jorropo mentioned this pull request Jul 26, 2022
Closed
@BigLep BigLep requested a review from guseggert August 4, 2022 15:48
@Jorropo Jorropo mentioned this pull request Aug 5, 2022
Merged
@Jorropo Jorropo force-pushed the split branch 2 times, most recently from 5bb5742 to 9a2d8ea Compare August 5, 2022 23:44
@Jorropo Jorropo marked this pull request as ready for review August 5, 2022 23:44
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 6, 2022

"it works on my machine" (I hate race conditions)

Maybe I should try rebasing this on some of your race fixing @guseggert ?

@Jorropo
test: remove TestTracer
1ac4824 
This test is exceptionally racy and IMO useless (you can go read the 10 lines of code making up tracing and convaince yourself it's working.)
guseggert
guseggert suggested changes Aug 8, 2022
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
polyfill.go Outdated Show resolved Hide resolved
server/forward.go Outdated Show resolved Hide resolved
network/connecteventmanager.go Show resolved Hide resolved
metrics/gen.go Outdated Show resolved Hide resolved
@guseggert
Copy link
Contributor

Can't comment on renamed files, but shouldn't we leave /docs in the root dir instead of moving to /client/docs ?

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 8, 2022

Can't comment on renamed files, but shouldn't we leave /docs in the root dir instead of moving to /client/docs ?

Yeah I'll fix.

@Jorropo Jorropo requested a review from guseggert August 11, 2022 16:25
@guseggert
Copy link
Contributor

Side note: on Windows and Mac, the TestSessionFailingToGetFirstBlock test is now consistently failing, but nothing was changed in that code. It was already racy and failing often to begin with. I'm guessing that the refactor changed the order that tests are run which is causing that to fail now. But since nothing was changed there, I'm going to move forward. We can fix that later.

@guseggert guseggert merged commit 5b013e0 into ipfs:master Aug 13, 2022
@Jorropo Jorropo deleted the split branch August 15, 2022 12:18
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
Closed
72 tasks
@aschmahmann aschmahmann mentioned this pull request Jan 27, 2023
Open
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
@guseggert
Merge pull request ipfs/go-bitswap#570 from Jorropo/split
ec22e05 
feat: split client and server

This commit was moved from ipfs/go-bitswap@5b013e0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guseggert guseggert guseggert approved these changes

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split server & client and create message dispatcher object
2 participants
@Jorropo @guseggert