Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve testing #103

Merged
merged 2 commits into from
Jul 3, 2023
Merged

feat: improve testing #103

merged 2 commits into from
Jul 3, 2023

Conversation

laurentsenta
Copy link
Contributor

  • fix tooling test suite
  • run go test tooling
  • more explicit workflow names

@laurentsenta
Copy link
Contributor Author

laurentsenta commented Jun 30, 2023

@galargh I'm thinking about dogfooding unified CI with this repo, but I don't want to run the test in ./tests: that's the project's output, they need provisioning, running daemons, etc. more like an e2e test suite.

I'm thinking either

  1. we add build tags support, similar to skip32bit in configuration ,
  2. we just remove the ./tests folder during the setup actions.

(1) might not be useful outside of gway conformance and (2) seems to just work ¯\(ツ)/¯, wdyt?

@galargh
Copy link
Contributor

galargh commented Jul 3, 2023

That's a swell idea! I think we should go with 2. (at least for now). The main reason is quite selfish, we need to do a looot of changes in uCI in July to get us closer to protocol/.github#514 before Go 1.21 is out so if we can limit other changes in the meantime, that's great. Also, if we have uCI in Gateway Conformance, it'll be extremely useful for testing if our changes to uCI as a whole work as expected :)

@laurentsenta laurentsenta marked this pull request as ready for review July 3, 2023 11:17
@laurentsenta laurentsenta merged commit 83c659a into main Jul 3, 2023
2 of 3 checks passed
@laurentsenta laurentsenta mentioned this pull request Jul 3, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants