refactor: replace boxo/ipld/car by ipld/go-car #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
- Coverage 51.45% 48.64% -2.82%
==========================================
Files 280 245 -35
Lines 33456 29767 -3689
==========================================
- Hits 17216 14480 -2736
+ Misses 14501 13860 -641
+ Partials 1739 1427 -312
|
1 task
Jorropo
requested changes
Jun 29, 2023
There was a problem hiding this comment.
boxo/cmd/boxo-migrate/internal/config.go
Line 42 in a91e44d
- "github.com/ipld/go-car": "github.com/ipfs/boxo/ipld/car",
+ "github.com/boxo/ipld/car": "github.com/ipld/go-car",
Jorropo
approved these changes
Jun 29, 2023
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218.
Kubo Sharness is expected to fail here since Kubo can't build without being updated. See PR above.