fix: GetIPNSRecord example gateway implementation #158
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
fix/example-ipns-key
branch
from
6988361
to
b0771a9
Compare
hacdias
changed the title
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 19.63% 19.62% -0.02%
==========================================
Files 100 100
Lines 11046 11053 +7
==========================================
Hits 2169 2169
- Misses 8590 8597 +7
Partials 287 287
|
lidel
approved these changes
Feb 10, 2023
lidel
force-pushed
the
fix/example-ipns-key
branch
from
b0771a9
to
5993a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
GetIPNSRecordin the gateway examples. The issue here was that the routing.ValueStore expects a multihash encoded key instead of a readable string.