Feat: issue evm event on L1 nft mint #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoe
approved these changes
Jul 8, 2024
dessaya
approved these changes
Jul 10, 2024
|
|
||
| // abort if num of requests is above max_uint16. | ||
| if reqIndex+1 == math.MaxUint16 { | ||
| break |
There was a problem hiding this comment.
Maybe add a log or similar? Becasue "errors should never pass silently".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following block after minting a L1 NFT form the chain (the first block where said NFTID is known), The committee will now produce an EVM event, so that EVM client applications (indexers/explorers/wallets) can account for the new NFT.
misc: