Interfaces #277
Merged
Interfaces #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add interfaces.py to process responses into third-party library objects
- Use existing dataset - Pass requests_kwargs to 'to_pandas' method
|
PS. please add the |
ocefpaf
reviewed
Nov 7, 2022
Sorry! Missed that completely and we are past the deadline!! Please ping me directly next time. |
- Add protocol check to interfaces function - Add self.protocol in ERDDAP.to_ncCF method
- Don't rename netCDF4 Dataset class - Change requests_kwargs default to None - Raise exception as object - Raise ValueError (instead of return) - Get rid of iris exception handling block (in favour of pinning latest version)
vinisalazar
commented
Nov 16, 2022
There was a problem hiding this comment.
Hi @ocefpaf @abkfenris, I addressed all comments that we had noted down, so I think this is ready to be reviewed again.
ocefpaf
reviewed
Nov 16, 2022
ocefpaf
reviewed
Nov 16, 2022
ocefpaf
reviewed
Nov 16, 2022
vinisalazar
added a commit
to vinisalazar/erddapy
that referenced
this pull request
Nov 16, 2022
Code review for ioos#277. Co-authored-by: Filipe <ocefpaf@gmail.com>
- Initialise dict with curly brackets - Improve exception handling in function 'to_pandas' - Improve error message in function 'to_ncCF' Co-authored-by: Filipe <ocefpaf@gmail.com>
vinisalazar
force-pushed
the
interfaces
branch
from
b02fa00
to
b4d9d37
Compare
ocefpaf
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR creates module
core.interfaces, with methods to use URLs to generate third-party datasets. These methods are used in theERDDAPclass.I rebased the
classesbranch from #267 with this branch.If you could pay special attention to review how
kwargsare being propagated across methods, that would be great.Thanks,
Vini