This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Create flat bundles & ship module entry #78
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,5 @@ coverage | |
| .vscode | ||
| .idea | ||
| lib/ | ||
| _book/ | ||
| es/ | ||
| _book/ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| { | ||
| "presets": ["env", "react", "stage-3"] | ||
| } | ||
| { "presets": ["./.babelrc.js"] } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| const { BABEL_ENV, NODE_ENV } = process.env | ||
|
|
||
| const cjs = BABEL_ENV === 'cjs' || NODE_ENV === 'test' | ||
|
|
||
| module.exports = { | ||
| presets: [ | ||
| ['env', { loose: true, modules: false }], | ||
| 'react', | ||
| 'stage-3', | ||
| ], | ||
| plugins: [ | ||
| cjs && 'transform-es2015-modules-commonjs', | ||
| ].filter(Boolean), | ||
| } |
This file was deleted.
Oops, something went wrong.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a common approach? I haven't seen many projects with anything other than a
babelrcfile and anenvnode for variations (although they do require multiple build scripts to seperate them).Are there any benefits one way or the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an useful hack to construct ur configs with javascript instead of plain JSON. Upcoming babel@7 will have support for
.babelrc.jsby default so you will be able to remove this "proxy".babelrcfileI was always a little bit confused about how merging is done when specifying
envin.babelrc- and this had to memorized and checked each time, when with.babelrc.jsI just know instantly what's the output config based on javascript conditions, without anything being automated (sometimes unintuitively for me) by babel itselfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍