Explicitly report error to the user when one of the following command fails (addFile, addExistingFile, addFileAbove, addFileBelow) #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fails (addFile, addExistingFile, addFileAbove, addFileBelow)
baronfel
approved these changes
Mar 13, 2023
|
Lovely change, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to ionide/FsAutoComplete#1076 but doesn't need it in order to be merged.
This PR improve the reported error in VSCode if the LSP server detected a problem when running the commands (addFile, addExistingFile, addFileAbove, addFileBelow) and that problem was not detected up front by Ionide.
Old error
old_error_report.mp4
New error
new_error_report.mp4