Merge branch 'main' into transparent-compiler

RELEASE_NOTES.md

@@ -1,3 +1,9 @@
+### 7.19.1 - 25.04.2024
+* ADDED: [Add config entry for parens analyzer](https://github.com/ionide/ionide-vscode-fsharp/pull/1994) (Thanks! @brianrourkeboll!)
+* ADDED: [Adds arbitrary additional arguments to be passed to fsac](https://github.com/ionide/ionide-vscode-fsharp/pull/2004) (Thanks @TheAngryByrd!)
+* FIX: [Escape quotes in test filter expressions](https://github.com/ionide/ionide-vscode-fsharp/pull/1999) (Thanks @farlee2121!)
+* Update to FSAC 0.72.1. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.72.1) for more details.
+
 ### 7.18.2 - 07.03.2024
 
 * Update to FSAC 0.71.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.71.0) for more details.

paket.lock

@@ -241,4 +241,4 @@ STORAGE: PACKAGES
 RESTRICTION: == netstandard2.0
 NUGET
   remote: https://api.nuget.org/v3/index.json
-    fsautocomplete (0.71)
+    fsautocomplete (0.72.1)

release/CHANGELOG.md

@@ -1,3 +1,9 @@
+### 7.19.0 - 25.04.2024
+* ADDED: [Add config entry for parens analyzer](https://github.com/ionide/ionide-vscode-fsharp/pull/1994) (Thanks! @brianrourkeboll!)
+* ADDED: [Adds arbitrary additional arguments to be passed to fsac](https://github.com/ionide/ionide-vscode-fsharp/pull/2004) (Thanks @TheAngryByrd!)
+* FIX: [Escape quotes in test filter expressions](https://github.com/ionide/ionide-vscode-fsharp/pull/1999) (Thanks @farlee2121!)
+* Update to FSAC 0.72.1. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.72.1) for more details.
+
 ### 7.18.2 - 07.03.2024
 
 * Update to FSAC 0.71.0. Check out the [release notes](https://github.com/fsharp/FsAutoComplete/releases/tag/v0.71.0) for more details.

release/package.json

@@ -574,6 +574,14 @@
           },
           "type": "array"
         },
+        "FSharp.fsac.fsacArgs": {
+          "default": [],
+          "description": "additional CLI arguments to be provided to FSAC itself. Useful for flags that aren\u0027t exposed in the settings or CLI arguments that only exist in custom built versions of FSAC. Requires restart.",
+          "items": {
+            "type": "string"
+          },
+          "type": "array"
+        },
         "FSharp.fsac.gc.conserveMemory": {
           "markdownDescription": "Configures the garbage collector to [conserve memory](https://learn.microsoft.com/en-us/dotnet/core/runtime-config/garbage-collector#conserve-memory) at the expense of more frequent garbage collections and possibly longer pause times. Acceptable values are 0-9. Any non-zero value will allow the [Large Object Heap](https://learn.microsoft.com/en-us/dotnet/standard/garbage-collection/large-object-heap) to be compacted automatically if it has too much fragmentation. Requires restart.",
           "type": "integer",
@@ -841,6 +849,11 @@
             "FSharp.simplifyNameAnalyzer"
           ]
         },
+        "FSharp.unnecessaryParenthesesAnalyzer": {
+          "default": false,
+          "description": "Enables detection of unnecessary parentheses",
+          "type": "boolean"
+        },
         "FSharp.smartIndent": {
           "default": false,
           "description": "Enables smart indent feature",
@@ -1795,5 +1808,5 @@
     "type": "git",
     "url": "https://github.com/ionide/ionide-vscode-fsharp.git"
   },
-  "version": "7.18.2"
+  "version": "7.19.1"
 }

src/Core/LanguageService.fs

@@ -903,6 +903,8 @@ Consider:
 
                     exeOpts.env <- exeEnv
 
+                    let additionalFSACArgs = "FSharp.fsac.fsacArgs" |> Configuration.get [||]
+
                     let args =
                         [ yield! fsacDotnetArgs
                           yield fsacPath
@@ -925,7 +927,8 @@ Consider:
                               let storageDir = uri.fsPath
                               yield "--state-directory"
                               yield storageDir
-                          | None -> () ]
+                          | None -> ()
+                          yield! additionalFSACArgs ]
                         |> ResizeArray
 
                     let executable = createEmpty<Executable>