Adjust for 1-based column indexing #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this require changes on the consumer side? |
rneatherway
force-pushed
the
col-1-indexed
branch
from
ece8298
to
6a912f6
Compare
|
Probably, yes. This is making it how it was supposed to be all along (both lines and columns 1-based like FCS). However, Emacs was sending 0-based and so will need to be updated. I will broadcast this more widely when I release 0.18. |
Add unit test project to check parsing functionality is correct
rneatherway
force-pushed
the
col-1-indexed
branch
from
6a912f6
to
8ace17d
Compare
rneatherway
added a commit
that referenced
this pull request
Jun 3, 2015
Adjust for 1-based column indexing
|
Hmm - looking at my own code it seems I am already sending 1 based column indices. How did that ever work? :) |
|
For most operations FCS likes to be told the last character of an identifier as its location, so FSAC adjusts this for you and it ends up being quite robust to small mistakes. |
vasily-kirichenko
pushed a commit
to vasily-kirichenko/FsAutoComplete
that referenced
this pull request
Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test project to check parsing functionality is correct