Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzers support #1217

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Dec 22, 2023

This updates the analyzers support to the latest SDK.
We have two analyzer collections ready to use:

Some analyzers come with fixes. See videos below.
Users can filter with the new settings FSharp.excludeAnalyzers xor FSharp.includeAnalyzers which analyzers they want to exclude or include in their experience.
In a certain way, this concludes all the work that was invested in the analyzers over the last couple of months.
Thanks to everyone involved 🚀

RecordUpdateAnalyzerFix.mp4
UnionCaseShadow.mp4

src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fsi Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
src/FsAutoComplete/LspHelpers.fs Fixed Show fixed Hide fixed
@dawedawe dawedawe marked this pull request as ready for review January 10, 2024 12:56
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but have you seen the Ubuntu format error? It's been happening somewhat frequently but I haven't been able to figure out how to reproduce it.

@dawedawe
Copy link
Contributor Author

LGTM, but have you seen the Ubuntu format error? It's been happening somewhat frequently but I haven't been able to figure out how to reproduce it.

Thanks for the review.
Yes, I've seen that in the past and also banged my head against it. But no luck :(
I'll try again in the next couple of days.

@TheAngryByrd
Copy link
Member

Thanks @dawedawe and @nojaf!

@TheAngryByrd TheAngryByrd merged commit 4ac4b87 into ionide:main Jan 14, 2024
14 checks passed
@dawedawe dawedawe deleted the update_analyzers_support branch January 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants