New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't put a colon in front of the type if the parameter name is empty #1061

Merged

baronfel merged 2 commits into ionide:main from dawedawe:improve_signature_format_for_empty_param_names

Feb 23, 2023

Contributor

dawedawe commented Feb 22, 2023

Currently the signature shows a colon before the type of a parameter even in case of an empty parameter name, which looks a little strange imho:

So let's drop the colons in such a case:

dawedawe added 2 commits

February 23, 2023 00:37


          Don't put a colon in front of the type if the parameter name is empty

003d0e2


          Format

7f87ea1

Contributor

baronfel commented Feb 23, 2023

This LGTM - thanks for the contribution @dawedawe!

baronfel merged commit f6c1ca0 into ionide:main

dawedawe deleted the improve_signature_format_for_empty_param_names branch

February 23, 2023 06:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet