fix(checkbox): align checkbox properly in item using start alignment #29850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Sep 9, 2024
| // Checkboxes that are not slotted inside an item and are not used with a | ||
| // stacked label should have margins equal to those of the label. | ||
| :host(.in-item) .label-text-wrapper, | ||
| :host(.in-item:not(.checkbox-label-placement-stacked):not([slot])) .native-wrapper { |
There was a problem hiding this comment.
Slotted checkboxes are excluded because the following would otherwise result in increased item height:
<ion-item>
<ion-checkbox slot="start">Start</ion-checkbox>
Checkbox
</ion-item>
tanner-reits
reviewed
Sep 9, 2024
BenOsodrac
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29837
What is the current behavior?
The checkbox is not aligned properly to the top when using a long label with
alignment="start"inside of anion-item:What is the new behavior?
.native-wrapper(checkbox) as the label.Does this introduce a breaking change?
Other information
Note
The alignment on the Material Design checkbox is still slightly off. I could add margin directly to its checkbox but then it would change the margin of the checkbox in all use cases.