Fix(upload): Remove entity parsing to fix ionic-team/ionic-cli#452 (c…

…omment)
ionic-team · Jul 1, 2015 · b757d38 · b757d38
1 parent c133c05
commit b757d38
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/lib/upload.js b/lib/upload.js
@@ -250,8 +250,9 @@ Upload.addCacheBusters = function addCacheBusters(indexPath) {
 
   var randomString = Math.floor(Math.random() * 100000);
   var indexHtml = fs.readFileSync(indexPath, 'utf8');
-  var $ = cheerio.load(indexHtml);
+  var $ = cheerio.load(indexHtml, { decodeEntities: false });
   var urlObj;
+
   try {
     $('script').each(function(i, el){
       if (typeof el.attribs.src === "undefined") return true; //continue

diff --git a/spec/index.html b/spec/index.html
@@ -16,5 +16,6 @@
       </ion-nav-back-button>
     </ion-nav-bar>
     <ion-nav-view></ion-nav-view>
+    <paper-item ng-click="goToState('dash')">Test item with apostrophes</paper-item>
   </body>
 </html>
diff --git a/spec/upload.spec.js b/spec/upload.spec.js
@@ -61,6 +61,10 @@ describe('Upload', function() {
         //Fix for https://github.com/driftyco/ionic-cli/issues/452
         var bomIndex = indexHtml.indexOf('&#xFEFF;');
         expect(bomIndex).toBe(-1);
+
+        //Fix for https://github.com/driftyco/ionic-cli/issues/452#issuecomment-117376542
+        var aposIndex = indexHtml.indexOf("goToState('dash')");
+        expect(aposIndex).not.toBe(-1);
       })
       .catch(function(ex){
         expect('this').toBe(ex.stack);