Update templates #472
Merged
Update templates #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosd
force-pushed
the
template-update
branch
from
c1e2d33
to
60aebd5
Compare
bosd
force-pushed
the
template-update
branch
from
60aebd5
to
8ade57f
Compare
rmilecki
reviewed
Feb 18, 2023
| fields: | ||
| amount: | ||
| parser: regex | ||
| regex: Total to pay EUR\s+(\d?.?\d{1,4}[,]\d{2}) |
There was a problem hiding this comment.
1 .? was probably meant to be \.?
2. [,] can be simplified to ,
| type: float | ||
| amount_tax: | ||
| parser: regex | ||
| regex: \d{2}[%]\s+\w\s+\d{1,4}[,]\d{2}\s+(\d{1,4}[,]\d{2}) |
There was a problem hiding this comment.
You can probably just use % instead of [%] (same applies to [,] and other regexes below)
|
I know it's still a draft, but I took a quick look at it anyway, I hope you don't mind |
No you're welcome. Last period, I start using this lib a lot. Learned so much more about regexes. |
bosd
force-pushed
the
template-update
branch
2 times, most recently
from
141df51
to
67b2940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an update on some templates