Allow null values for decimal fields (#539)

* Allow null values for decimal fields - fixes #538 * Update release notes * Fix initial value
inventree · Sep 27, 2024 · 538a3d6 · 538a3d6
1 parent ad48e5e
commit 538a3d6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/assets/release_notes.md b/assets/release_notes.md
@@ -1,3 +1,8 @@
+### 0.16.5 - September 2024
+---
+
+- Allow blank values to be entered into numerical fields
+
 ### 0.16.4 - September 2024
 ---
 

diff --git a/lib/api_form.dart b/lib/api_form.dart
@@ -471,7 +471,14 @@ class APIFormField {
   // Construct a floating point numerical input field
   Widget _constructFloatField() {
 
-    double initial = double.tryParse(value.toString()) ?? 0;
+    // Initial value: try to cast to a valid number
+    String initial = "";
+
+    double? initialNumber = double.tryParse(value.toString());
+
+    if (initialNumber != null) {
+      initial = simpleNumberString(initialNumber);
+    }
 
     return TextFormField(
       decoration: InputDecoration(
@@ -481,9 +488,15 @@ class APIFormField {
         helperStyle: _helperStyle(),
         hintText: placeholderText,
       ),
-      initialValue: simpleNumberString(initial),
+      initialValue: initial,
       keyboardType: TextInputType.numberWithOptions(signed: true, decimal: true),
       validator: (value) {
+        value = value?.trim() ?? "";
+
+        // Allow empty numbers, *if* this field is not required
+        if (value.isEmpty && !required) {
+          return null;
+        }
 
         double? quantity = double.tryParse(value.toString());