Fix plugin pickeling #5412
Merged
Fix plugin pickeling #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree canceled.
|
wolflu05
added
bug
4 tasks
|
@wolflu05 thanks for this fix. I still think we need to assess whether the entire setting object should be cached. I'll open a new issue to discuss. |
|
@SchrodingersGat Are we gonna backport this fix? |
wolflu05
added
backport
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 1fe382e)
SchrodingersGat
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix that just removes the plugin from the model state for pickling, as pickling somehow does not work for views. But afaik the actual plugin instance is not needed to be stored in cache.
resolves #5408