modal: fix record adding to a community #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrcastro2
commented
Sep 2, 2024
jrcastro2
commented
- closes Bug on adding a record to a community #2821
jrcastro2
force-pushed
the
fix-submission-modal
branch
from
8d11744
to
0a814d5
Compare
alejandromumo
approved these changes
Sep 2, 2024
.../js/invenio_app_rdm/landing_page/RecordCommunitySubmission/RecordCommunitySubmissionModal.js
Outdated
Show resolved
Hide resolved
zzacharo
reviewed
Sep 2, 2024
| // no nee to process the response with the schema serializer | ||
| const response = await http.post(recordCommunityEndpoint, data, { | ||
| headers: { | ||
| "Accept": "application/json", |
There was a problem hiding this comment.
Shouldn't this be the other way around and fix the endpoint to accept the inveniordm.json+vnd? @slint
There was a problem hiding this comment.
I am jumping in since I might have a bit more context. (However anyone is welcomed to comment!)
The endpoint currently accepts the inveniordm.json+vnd content type. However, it is part of a resource that utilizes a serializer with a schema expecting a standard community dictionary object. Since we are passing a custom dictionary structure instead, the schema validation fails when using our custom Accept header. As a result, we have decided to disable this header in both the backend and frontend for this endpoint.
jrcastro2
force-pushed
the
fix-submission-modal
branch
from
0a814d5
to
05b4115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.