fix test and await on publishing

intuit · Mar 5, 2022 · 7c4682f · 7c4682f
1 parent cf11837
commit 7c4682f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/plugins/gradle/__tests__/gradle.test.ts b/plugins/gradle/__tests__/gradle.test.ts
@@ -215,7 +215,7 @@ describe("Gradle Plugin", () => {
       const spy = jest.fn();
       exec.mockReturnValueOnce(properties).mockImplementation(spy);
 
-      await hooks.canary.promise({ bump: Auto.SEMVER.patch, canaryIdentifier: "canary123" });
+      await hooks.canary.promise({ bump: Auto.SEMVER.patch, canaryIdentifier: "-canary123" });
 
       expect(spy).toHaveBeenCalledWith(expect.stringMatching("gradle"), [
         "updateVersion",

diff --git a/plugins/gradle/src/index.ts b/plugins/gradle/src/index.ts
@@ -144,6 +144,7 @@ export default class GradleReleasePluginPlugin implements IPlugin {
 
   /** Tap into auto plugin points. */
   apply(auto: Auto) {
+    /** Call gradle publish, if exists, otherwise log warning */
     const publish = async () => {
       const { publish } = this.properties;
 
@@ -242,7 +243,7 @@ export default class GradleReleasePluginPlugin implements IPlugin {
     );
 
     auto.hooks.publish.tapPromise(this.name, async () => {
-      publish();
+      await publish();
 
       await execPromise("git", [
         "push",
@@ -276,7 +277,7 @@ export default class GradleReleasePluginPlugin implements IPlugin {
           false
         );
 
-        publish();
+        await publish();
 
         return canaryVersion;
       }
@@ -330,7 +331,7 @@ export default class GradleReleasePluginPlugin implements IPlugin {
           false
         );
 
-        publish();
+        await publish();
 
         return preReleaseVersions;
       }