Newer docker version #1419
Merged
Newer docker version #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aequitas
force-pushed
the
newer-docker-versions
branch
5 times, most recently
from
8a8c548
to
27f1a24
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
17 times, most recently
from
457f08a
to
df979ef
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
2 times, most recently
from
b6fc41d
to
fd6dc84
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
from
fd6dc84
to
d50e45a
Compare
… Docker/Compose Due to some changes in the handling of config files in Compose, some configurations might not work on older or newer versions of Docker/Compose. Use a matrix to test both.
…ronment. Due to a change in Docker's DNS resolver (moby/moby#47589) in version 25.0.5 (https://docs.docker.com/engine/release-notes/25.0/#2505), traffic to the mock resolver used in integration/batch tests is no longer forwarded. This is fixed in moby/moby#47822 in version 26.0.3 (https://docs.docker.com/engine/release-notes/26.0/#2603). - Temporary add upgrade commands to CI because 26.0.3 is not yet in the default CI image - Add checks to warn about incompatible versions - Add documentation to help developers get the right versions
Somehow Chromium disables IPv6 resolving when there is no IPv6 default route or when it cannot connect to a specific address: https://issues.chromium.org/issues/40435291 Switching to Firefox as browser until this can be solved.
- Docker Compose 2.24 broke behaviour we rely on for merging .env files. Versions since 2.27.1 restore this funcitonality: docker/compose#11824
mxsasha
force-pushed
the
newer-docker-versions
branch
from
d50e45a
to
3a99706
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
from
cf94048
to
bf0e95f
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
5 times, most recently
from
cb7f9fe
to
ba377b6
Compare
aequitas
force-pushed
the
newer-docker-versions
branch
from
ba377b6
to
4f33015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with newer Docker/Compose versions:
!overridein the YAML file explicitly we get the expected behaviour on newer version which is backwards compatible with older versions as well.ipv6.internet.nldomains and the connection test) to fail. Switching to Firefox as browser used for testing. There might be a way to override this behaviour in Chrome using theIPv6ReachabilityOverrideEnabledpolicy, but so far I have not been able to make it work inside the playwright Docker image using available documentation. Firefox does seem a little bit slower on executing the tests so we might want to switch back to Chrome if we can.no configuration file provided: not found). This has been fixed in 2.27.0 but seems to be broken again in 2.27.1 due to [BUG] Incompatible.envfile behavior docker/compose#11880. Currently Compose in CI will be pinned to 2.27.0.Besides the fixes the following changes are included: