feat: UX change in Author Page #9934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mekarpeles
reviewed
Oct 4, 2024
Comment on lines
+132
to
+133
| <div style="display: flex; align-items: center;"> | ||
| <div style="margin-right: 15px; margin-top:10px "> |
There was a problem hiding this comment.
Please avoid inline styles :)
|
Looks much better, now we just have to clean up our code a bit so we're not using inline styles. |
mekarpeles
added
the
Needs: Submitter Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9928
Design Changes on the UX Author Page. Changed the position of sort dropper
Technical
The sort drop has been moved down for better visibility.
Testing
Please visit the following page ex:
/authors/OL18319A/Mark_TwainScreenshot
Stakeholders