Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MergeUI/all vue components easier to test locally #9854

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Sep 9, 2024

Work towards #9811

Technical

  • Give MergeUI the same config url parameters that LibraryExplorer has for controlling data sources. This makes it easy to use the live-reloading dev environment, but have it hooked up to either prod or localhost to fetch data.
  • Create a new script for testing vue components, npm run serve --component=MergeUI. No more needing to modify _dev.js!
    • Note: made use of an npm feature I learned about: If you call an npm script with an argument, like npm run serve --component=Foo, it automatically sets an environment variable to npm_config_component! Very handy. You can then access this from the script using the language's normal environment variable features, e.g. process.env.npm_config_component.
  • Fix some long-standing bugs preventing vue live server usage on gitpod

Testing

  • ✅ Tested the new script on git bash and on windows command line. Worked.
  • ✅ Tested trying to do a merge failed because it hits localhost for the save call by default
  • ✅ Tested LibraryExplorer works with the script.
  • ✅ Tested the README instructions in gitpod.

Screenshot

Stakeholders

@benbdeitch @jimchamp

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.42%. Comparing base (ce16a79) to head (e725ba3).
Report is 385 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9854      +/-   ##
==========================================
+ Coverage   16.06%   16.42%   +0.36%     
==========================================
  Files          90       92       +2     
  Lines        4769     4907     +138     
  Branches      832      856      +24     
==========================================
+ Hits          766      806      +40     
- Misses       3480     3565      +85     
- Partials      523      536      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbdeitch
Copy link
Collaborator

I've repeated all the testing over Gitpod, and reviewed the code. Great job, it looks fantastic to me, and seems to work perfectly.

@cdrini cdrini merged commit 59c8fa5 into internetarchive:master Sep 10, 2024
5 checks passed
@cdrini cdrini deleted the feature/merge-ui-configs branch September 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants