Require Tag type on creation, update #9783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds default "Select" option. Ensures that option order is maintained, regardless of what type of tag is being edited. This change more closely matches the type options in the "Add tag" view, making it easier to combine these two very similar templates in the near future.
for more information, see https://pre-commit.ci
jimchamp
commented
Aug 21, 2024
| @@ -62,6 +66,10 @@ def POST(self): | |||
| raise web.unauthorized(message='Permission denied to add tags') | |||
|
|
|||
| i = utils.unflatten(i) | |||
|
|
|||
| if not i.tag_name or not i.tag_type: | |||
There was a problem hiding this comment.
Will DRY this to use validate_tag when work begins on #9784. Today, the "Tag Name" input is identified differently in both forms (name in one; tag_name in the other).
jimchamp
commented
Aug 21, 2024
Comment on lines
+38
to
+44
| <select name="tag_type" id="tag_type" required> | ||
| <option value="">$_("Select")</option> | ||
| $ tag_types = get_tag_types() | ||
| $for tag_type in tag_types: | ||
| $if tag_type != page.tag_type: | ||
| $if tag_type == page.tag_type: | ||
| <option value="$tag_type" selected>$tag_type</option> | ||
| $else: |
There was a problem hiding this comment.
These changes make this tag type selector roughly the same as the selector in the "add tag" view, and were largely made to support #9784.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9780
Changes to require
tag_typeandnamewhenever a Tag is created or updated.Technical
Testing
Important
Until #9776 is merged, validations will not occur when
?m=editis used to navigate to the edit view.While logged in as a
librarian, test the following:/tag/addpage and attempt to submit the form without filling the Tag name input, or selecting a Tag type. Expect to see "Required field" messages by these inputs.POSTrequests to the/tag/addendpoint. Ensure that you receive a400when either thenameortag_typeis missing from the request.Screenshot
Stakeholders