Add Support for tabular data entry in Bulk Search #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbdeitch
added
the
Type: Subtask of Epic
benbdeitch
force-pushed
the
9699/feature/add-tabular-support-to-bulk-search
branch
from
f8affdd
to
1bb951a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9709 +/- ##
==========================================
+ Coverage 16.06% 16.45% +0.39%
==========================================
Files 90 91 +1
Lines 4769 4899 +130
Branches 832 853 +21
==========================================
+ Hits 766 806 +40
- Misses 3480 3559 +79
- Partials 523 534 +11 ☔ View full report in Codecov by Sentry. |
…han as a part of the vue component.
…entify when it's the active extractor of BulkSearchState.
benbdeitch
force-pushed
the
9699/feature/add-tabular-support-to-bulk-search
branch
from
1bb951a
to
000d8a3
Compare
mekarpeles
added
the
Priority: 1
cdrini
reviewed
Aug 28, 2024
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
cdrini
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
cdrini
reviewed
Aug 28, 2024
openlibrary/components/BulkSearch/components/BulkSearchControls.vue
Outdated
Show resolved
Hide resolved
cdrini
added
Needs: Submitter Input
benbdeitch
force-pushed
the
9699/feature/add-tabular-support-to-bulk-search
branch
from
6f8d11e
to
d1066ac
Compare
github-actions
bot
removed
the
Needs: Submitter Input
cdrini
reviewed
Sep 4, 2024
cdrini
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9699
This PR adds another new child of the AbstractExtractor class. The TableExtractor allows for data to be copy-pasted from Google Sheets or other spreadsheet services, and extracts the contents of the 'title' column and the 'author' column, if they exist.
Technical
Currently, the implementation allows for titles to be searched if the author column is empty. This has led to an odd interaction, where searching for 'Mark Twain' in the title ends up incorrectly pulling other books that he wrote. I'll be debugging that over the next day or so, but I figured I might as well put it up for review.
Testing
Create a table in Google Spreadsheets, then copy it into the input area of the
/search/bulkpage. Select the bottom extraction option, and click 'extract books'. Please ensure that you have titled your columns appropriately.Screenshot
Stakeholders
@cdrini