Feature add ids to works #8346
Draft
Feature add ids to works #8346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8346 +/- ##
==========================================
- Coverage 16.66% 16.58% -0.09%
==========================================
Files 83 83
Lines 4422 4444 +22
Branches 757 763 +6
==========================================
Hits 737 737
- Misses 3202 3218 +16
- Partials 483 489 +6
|
davidscotson
force-pushed
the
feature/1797_ids_for_works
branch
from
18a048f
to
346f8dc
Compare
davidscotson
force-pushed
the
feature/1797_ids_for_works
branch
4 times, most recently
from
68dc489
to
d9b4059
Compare
fixes internetarchive#3430 and internetarchive#1797 Adds the option to add external ids (wikidata, VIAF) to works, based on the code for editions, with minor tweaks. Will autodetect the id type when possible, similar to functionality in the author id entry. Will accept urls for ids and automatically extract the id from them based on regex sourced from wikidata.
davidscotson
force-pushed
the
feature/1797_ids_for_works
branch
from
d9b4059
to
ce23536
Compare
|
I think the CI is currently failing due to an error from 3rd party server:
|
|
I've pushed a follow up commit, where some of the improvements over editions are backported to editions. I was going to do that as a seperate commit (and still can) but:
Will see how it goes. |
davidscotson
force-pushed
the
feature/1797_ids_for_works
branch
2 times, most recently
from
92f9c0a
to
ce23536
Compare
|
@davidscotson That error appears to be resolved on other PRs ; if you rebase off latest master that should hopefully fix it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3430 and #1797
Mostly re-using code from Edition ids and tweaking it for Works.
On top of that adds the auto detection of some ids (e.g. pasting in a wikidata or amazon id will auto-select that entry for you), similar to functionality on current Author id entry.
Also, adds the ability to paste in entire urls, which will then detect the right type of id and extract the specific id.
Note:
Displays the ids on the work/edition page though #3430 currently suggests this is optional, but I think the display is fairly inoffensive and would do for now.
Closes #3430
and
Closes #1797
Partially addresses #866 for this specific area.
feature
Technical
Requires server side set up to work, similar to the edition identifiers, it gets the list of ids to use from config stored on server, see instructions below.
Testing
You need to configure config/works with identifiers via:
/config/work.yml?m=edit
Before you can save any IDs.
Once you do you can add and remove IDs from works.
Screenshot
Stakeholders