Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Library of Congress Name Authority File (LC NAF) as identifier type #9791

Closed
tfmorris opened this issue Aug 22, 2024 · 3 comments · Fixed by #9812
Closed

Add Library of Congress Name Authority File (LC NAF) as identifier type #9791

tfmorris opened this issue Aug 22, 2024 · 3 comments · Fixed by #9812
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed]

Comments

@tfmorris
Copy link
Contributor

The Library of Congress Name Authority File is a strong identifier which should be supported for authors.

I'm not sure exactly where to extract these ids to in OL's data model.

I think they go in identifiers. I'm not sure why LC NAF isn't one of OpenLibrary's identifier options, but that's where I'd put all the ones listed above (in their primitive, not URI, form i.e. nr92001540 not http://id.loc.gov/authorities/names/nr92001540), assuming that LC NAF gets added as a valid identifier.

Originally posted by @tfmorris in #7724 (comment)
@tfmorris
Copy link
Contributor Author

pinging @mekarpeles for triage since it didn't get fancy template labels

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 23, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Response Issues which require feedback from lead labels Aug 23, 2024
@mekarpeles
Copy link
Member

mekarpeles commented Aug 23, 2024 •
edited
Loading

Breakdown

I believe we need to have a similar flow for authors than we do for editions identifiers:

Blocked by / depends on #9666

Related files:

@mekarpeles mekarpeles added State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] labels Aug 23, 2024
@tfmorris
Copy link
Contributor Author

Unblocked by the merge of #9769.

This could probably be expanded to include other national library identifiers like GND, BNF, etc in addition to LC NAF. It's weird that random outliers like Inventaire and Storygraph are included when national libraries aren't.

Of course, the first choice should be Wikidata, if an entry exists, since that forms the hub to all the other identifiers, but some authors have LCNAF, VIAF, GND, etc but not Wikidata.

Freso added a commit to Freso/openlibrary that referenced this issue Aug 27, 2024
@Freso
Add Library of Congress NAF as Author identifier
5013a91 
Adds Library of Congress Name Authority File (LC NAF) as an Author identifier.

The `label` has been shortened to just “Library of Congress” to
avoid having an obscenely long label in the drop-down lists and
also avoid obscure acronyms (“NAF”) in it that are likely to
cause more confusion than clarity.

The URI identifiers given by LoC themselves start with “http://” but I
have opted to use “https://” for the `url` so patrons etc. won’t need a
redirect or similar to get to the page.

Closes internetarchive#9791
@Freso Freso mentioned this issue Aug 27, 2024
Merged
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Aug 27, 2024
@hornc hornc removed the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Library of Congress NAF as Author identifier Freso/openlibrary
3 participants
@tfmorris @hornc @mekarpeles