-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Search Results Experience when 0 results #1001
Comments
We're going to fall back to the next |
History
We still don't want dead ends. The revised proposal is to:
|
I recommend looking at this through a different lens. Dead ends are unsatisfying, but the best solution is to avoid them in the first place, not to send the user on a detour down a different dead end. I recently copied the book title, "Cornell ’77: The Music, the Myth and the Magnificence of the Grateful Dead Show at Barton Hall," from an article and pasted it into the OpenLibrary search box resulting in exactly zero matches. Searching "All" instead of "Title" also returned zero matches. Switching to full-text search resulted in ... zero matches. Can you spot the one word (out of sixteen) that the article author transcribe wrong for Cornell '77: the music, the myth, and the magnificence of the Grateful Dead's concert at Barton Hall? If search returned results which were close (I consider 15 of 16 words close), there would be many fewer dead ends to worry about. This applies to single letter transpositions, small typos, and all the other things the Google & Duck Duck Go handle effortlessly, but completely stump OL Search. |
Would it be possible for the search function to look for each word, and display the results in order of most similar words? |
Hello, I am a student from the University Of Toronto. Would it be possible for me and my group to work on this in case this issue is still open? |
Related to #8740 |
@mekarpeles Hello Mek, I'd love to take this issue on. |
@mekarpeles I see noted that the issue was fixed by #1025 ..but when I search for a result with a typo, it's still turning up 0 results: Please clarify the reqs for this and happy to get to work on it. |
@tfmorris, @benbdeitch has been working on an fuzzy search effort #8873 to address #6923. An issue exists for this, a PR-in progress exists for this. @merwhite11 This issue is calling for something different, which is -- If you are on the See the design here for inspiration: #8884 (comment) We also want to do this in a way where (when possible) we're keeping the design of the different search pages consistent, see: #8891 |
@mekarpeles @jimchamp Context: Goal: Process:
Questions:
Future Issues / Out of scope:
References: Similar Partials use-case: https://github.com/internetarchive/openlibrary/blob/37db01e97fafaeec1f36951050b06f836442ca71/openlibrary/plugins/openlibrary/js/affiliate-links.js Partials docs (to be added to!): Separate but possibly overlapping issue of unifying UI for widget being worked on here: #8891 |
Thanks @merwhite11!
This section of our Frontend Guide may help. For this issue, you'll probably want to make a new For example, you could replace the existing markup in the That's the gist of it. I've glossed over a lot of things, so feel free to reach out over Slack if you have questions and would like a quicker response. |
Thanks @merwhite11! Just in case you didn't know, we have a loading indicator macro that can probably be used as a placeholder here. |
Opened the pull request and completed a draft of Partials docs revision: |
If the user is in
mode=ebooks
mode for search, but there are no results, we should fall back to searchmode=everything
and/or at least show the user some other options + a useful message which doesn't feel like a dead-endThe text was updated successfully, but these errors were encountered: