Fix compile issues #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eoghan1232
reviewed
May 9, 2023
johnoloughlin
force-pushed
the
fix_compile_issues
branch
2 times, most recently
from
8116be0
to
8a1c77b
Compare
Eoghan1232
reviewed
May 11, 2023
walshric
approved these changes
May 15, 2023
Eoghan1232
force-pushed
the
fix_compile_issues
branch
from
ccc0579
to
324ae13
Compare
johnoloughlin
force-pushed
the
fix_compile_issues
branch
9 times, most recently
from
3e6f6d2
to
a832cff
Compare
Closed
johnoloughlin
force-pushed
the
fix_compile_issues
branch
5 times, most recently
from
fefc9b5
to
70c9cec
Compare
Eoghan1232
reviewed
May 24, 2023
johnoloughlin
force-pushed
the
fix_compile_issues
branch
2 times, most recently
from
9485def
to
8b55aa8
Compare
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
As we upgrade to a never version of vpp (23.02) we are hitting build issues due to outdated go api files. This patch fixes this issue. Signed-off-by: John O'Loughlin <john.oloughlin@intel.com> Signed-off-by: Eoghan Russell <eoghan.russell@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
updates flagged by golangci-lint Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
when the pod spins up across the cluster it copies the userspace binary to the host and then terminates. kubernetes then interacts with this binary from the host Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
VPP changed default calue for SwIfIndex to 4294967295 As go was setting this to 0 the bridge was never found Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
johnoloughlin
force-pushed
the
fix_compile_issues
branch
from
8b55aa8
to
bb51497
Compare
|
Needed to force push as I rebased on master |
Code was commented out as api had changed, removing comment as testing shows this isn't needed Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
johnoloughlin
force-pushed
the
fix_compile_issues
branch
from
b28f468
to
b93c9b2
Compare
|
unsure where github.com/konsorten/go-windows-terminal-sequences v1.0.3/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ= comes from. Any tests I do on my linux system doesn't get this package |
johnoloughlin
force-pushed
the
fix_compile_issues
branch
from
b93c9b2
to
da0e178
Compare
Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
johnoloughlin
force-pushed
the
fix_compile_issues
branch
from
da0e178
to
3ff5cd3
Compare
Eoghan1232
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.