Bump kubernetes dependencies to v0.18.3 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multus-cni and network-attachment-definition-client moved their dependencies, so app-netutil won't build unless userspace-cni-network-plugin also is updated. Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
|
@garyloug @przemeklal PTAL |
|
@Billy99 LGTM. I need to build and test a bunch of changes from @patrickog11 this week. I can include this too. Question on the context.TODO() - is this something we need to come back and address later? Do you see us passing an actual context in future? Or should this be context.Background() ? |
|
@garyloug With reagrds to context.TODO(), I wrote you on Intel slack (long post). If we move completely to the device-info-spec, we won't need any of this code. |
|
@garyloug Any feedback? Need this upstream before I can push my app-netutil changes. |
|
@Billy99 sorry haven't been keeping an eye on Slack. Just reinstalled and read your post. Makes sense, will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multus-cni and network-attachment-definition-client moved their dependencies, so
app-netutil won't build unless userspace-cni-network-plugin also is updated.
Signed-off-by: Billy McFall 22157057+Billy99@users.noreply.github.com