update Makefile #170
Merged
update Makefile #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eoghan1232
reviewed
Sep 15, 2023
docker/userspacecni/Dockerfile
Outdated
| RUN go mod tidy | ||
| RUN make build | ||
| RUN cd userspace && go build -v |
There was a problem hiding this comment.
DL3003 warning: Use WORKDIR to switch to a directory
just fix these
|
PR LGTM just fix the issues from the actions and I will approve after. |
johnoloughlin
force-pushed
the
update_makefile
branch
5 times, most recently
from
1eecefd
to
2e7cd1c
Compare
Makefile now only runs docker build Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
johnoloughlin
force-pushed
the
update_makefile
branch
from
2e7cd1c
to
a05ee35
Compare
Eoghan1232
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile now only runs docker build