Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][PI][CUDA][HIP] Fix bugs that can cause events not to be waited on #8374

Merged
merged 3 commits into from
Feb 22, 2023
Merged

[SYCL][PI][CUDA][HIP] Fix bugs that can cause events not to be waited on #8374

merged 3 commits into from
Feb 22, 2023

Conversation

t4c1
Copy link
Contributor

@t4c1 t4c1 commented Feb 16, 2023 •
edited
Loading

Fixes two bug in CUDA PI and HIP PI that can cause waiting for events to do nothing:

  • The first one is an off-by-one error when checking if an event needs to be waited on
  • The second one is last_sync_compute_streams_ / last_sync_transfer_streams_ to a new value before checking the streams which can read these variables, expecting the old values.

Both of these are synchronization related and therefore hard to test for.

@t4c1 t4c1 requested a review from a team as a code owner February 16, 2023 12:53
@t4c1 t4c1 requested a review from jchlanda February 16, 2023 12:53
@sommerlukas sommerlukas mentioned this pull request Feb 16, 2023
Closed
@t4c1 t4c1 temporarily deployed to aws February 16, 2023 13:19 — with GitHub Actions Inactive
@zjin-lcf
Copy link
Contributor

Are they bugs in HIP PI ?

@t4c1
Copy link
Contributor Author

t4c1 commented Feb 16, 2023

That is a good point. Probably, I will check HIP tomorrow.

@t4c1 t4c1 requested a review from a team as a code owner February 17, 2023 08:12
@t4c1 t4c1 changed the title [SYCL][PI][CUDA] Fix bugs that can cause events not to be waited on [SYCL][PI][CUDA][HIP] Fix bugs that can cause events not to be waited on Feb 17, 2023
@t4c1 t4c1 temporarily deployed to aws February 17, 2023 08:46 — with GitHub Actions Inactive
aelovikov-intel
aelovikov-intel approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a dedicated codeowner for HIP plugin similar to CUDA?

@bader
Copy link
Contributor

bader commented Feb 18, 2023

@t4c1, to fix CI checks, please, merge latest commits from the sycl branch.

@t4c1 t4c1 temporarily deployed to aws February 18, 2023 12:24 — with GitHub Actions Inactive
@t4c1 t4c1 temporarily deployed to aws February 21, 2023 09:42 — with GitHub Actions Inactive
@t4c1 t4c1 temporarily deployed to aws February 21, 2023 12:52 — with GitHub Actions Inactive
@bader bader merged commit 1b22544 into intel:sycl Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchlanda jchlanda jchlanda approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t4c1 @zjin-lcf @bader @jchlanda @aelovikov-intel