Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intradocument hyperlinks in docs/MANUAL.md updated #983

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

imsahil007
Copy link
Contributor

As mentioned in #982 the hyperlinks for MANUAL.md weren't working.
This was happening as the way Markdown handles hyperlink is different in comparison to sphinx. I have updated all the links for this page(file).

@codecov-io
Copy link

Codecov Report

Merging #983 (7271731) into master (3d09b65) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   85.10%   85.03%   -0.08%     
==========================================
  Files         169      169              
  Lines        2854     2854              
  Branches      311      311              
==========================================
- Hits         2429     2427       -2     
- Misses        340      343       +3     
+ Partials       85       84       -1     
Flag Coverage Δ
longtests 85.03% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/version.py 70.00% <0.00%> (-10.00%) ⬇️
test/test_extractor.py 96.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d09b65...7271731. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm going to have to see if I can fix the markdown plugin I'm using to generate the table of contents so it doesn't revert these, though.

@terriko
Copy link
Contributor

terriko commented Nov 18, 2020

Oh, and next time you're fixing a known bug, github has some magic keywords so the bug will auto-close and it would be awesome if you could include them in the description. In case you wanted to read more about the options, here's a link: https://docs.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords

In this case, I'd want to see

Fixes #982

As you may have noticed, we triage the list of bugs less regularly than I close PRs, so this really helps us out!

@terriko terriko merged commit 8bd70c0 into intel:master Nov 18, 2020
@imsahil007 imsahil007 deleted the hyperlink branch November 26, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants