Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new contributor documentation #968

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Nov 11, 2020

  • Add imposter syndrome disclaimer (thanks @Niraj-Kamdar for suggesting this!)
  • Improve flow (so people get told about virtualenvs, tests, and black before trying to push a PR)
  • Add instructions for building documentation
  • Fill in basic info on tests, virtualenv

@codecov-io
Copy link

Codecov Report

Merging #968 (a4f6159) into master (5c079a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         169      169           
  Lines        2854     2854           
  Branches      311      311           
=======================================
  Hits         2427     2427           
  Misses        342      342           
  Partials       85       85           
Flag Coverage Δ
longtests 85.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c079a8...a4f6159. Read the comment docs.

@terriko terriko merged commit b33bc8a into intel:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants