cvedb will scrap data now

[imsahil007]

Closes #906

[codecov-commenter]

Codecov Report

Merging #908 into master will increase coverage by 2.62%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   84.73%   87.35%   +2.62%     
==========================================
  Files         169      169              
  Lines        2790     2791       +1     
  Branches      302      302              
==========================================
+ Hits         2364     2438      +74     
+ Misses        347      282      -65     
+ Partials       79       71       -8     

Flag	Coverage Δ
#longtests	87.35% <66.66%> (+2.62%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cve_bin_tool/async_utils.py	89.65% <ø> (ø)
cve_bin_tool/cli.py	86.46% <ø> (+3.00%)	⬆️
cve_bin_tool/cve_scanner.py	81.08% <ø> (ø)
cve_bin_tool/egg_updater.py	100.00% <ø> (ø)
cve_bin_tool/output_engine/html.py	19.44% <0.00%> (ø)
test/test_cli.py	96.00% <ø> (+16.00%)	⬆️
test/test_data/icecast.py	100.00% <ø> (ø)
test/test_json.py	89.65% <ø> (+20.68%)	⬆️
cve_bin_tool/cvedb.py	88.58% <100.00%> (+4.39%)	⬆️
cve_bin_tool/version_scanner.py	86.32% <0.00%> (+1.70%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4def96c...5eb1d6a. Read the comment docs.

[terriko]

This looks like you might need to rebase or something? It's got a rather large number of unrelated formatting changes, possibly due to a different version of black? They're not wrong it just makes it a pain to review.

[terriko]

Can we switch this to an f-string? We've stopped using + for string manipulation. More details here: https://github.com/intel/cve-bin-tool/blob/master/doc/CONTRIBUTORS.md#string-formatting

[terriko]

But other than that, this looks like what we need. Let's just get the PR cleaned up a little bit so we can merge it without needing fixes. Thanks! 👍

[imsahil007]

I revert back the changes after switching to f-string. I think this will work now

[terriko]

Also, totally late notice, but we're doing a meeting for pre-release and hacktoberfest preparation tomorrow at 9:30am US pacific (which would be 10pm in India assuming your github location is up to date). If you're interested and get this before we're done, we'll be on google meet: meet.google.com/dom-unde-bfk

[imsahil007]

This looks like you might need to rebase or something? It's got a rather large number of unrelated formatting changes, possibly due to a different version of black? They're not wrong it just makes it a pain to review.

It turns out I am using the same version of black we are using in tests. The tests tend to fail if I use an older version of black. @terriko Should I create another PR just for the formatting changes?

[imsahil007]

This looks like you might need to rebase or something? It's got a rather large number of unrelated formatting changes, possibly due to a different version of black? They're not wrong it just makes it a pain to review.

It turns out I am using the same version of black we are using in tests. The tests tend to fail if I use an older version of black. @terriko Should I create another PR just for the formatting changes?

I think we should either do this or stick to a single version of black instead of using the GitHub version

[terriko]

Thank you! Not sure what's up with black, but thank you very much for persevering!