Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package and module now uses Product as their name. #759

Merged
merged 8 commits into from
Jun 30, 2020
Merged

package and module now uses Product as their name. #759

merged 8 commits into from
Jun 30, 2020

Conversation

SinghHrmn
Copy link
Contributor

Changes

I have changed almost every file to use product instead of package and module.
I haven't changed any documentation. But I updated documentation for checker because that was important.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #759 into master will increase coverage by 6.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   81.51%   87.74%   +6.22%     
==========================================
  Files         136      136              
  Lines        2456     2456              
  Branches      302      302              
==========================================
+ Hits         2002     2155     +153     
+ Misses        381      231     -150     
+ Partials       73       70       -3     
Flag Coverage Δ
#longtests 87.74% <100.00%> (+6.22%) ⬆️
Impacted Files Coverage Δ
cve_bin_tool/OutputEngine.py 58.39% <ø> (ø)
cve_bin_tool/cli.py 88.04% <ø> (+5.43%) ⬆️
cve_bin_tool/csv2cve.py 66.00% <ø> (ø)
cve_bin_tool/scanner.py 85.38% <ø> (ø)
test/test_output_engine.py 98.85% <ø> (ø)
cve_bin_tool/checkers/__init__.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/bash.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/binutils.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/bluez.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/busybox.py 100.00% <100.00%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db7584...47418b5. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through and doing all of these. I've got a couple of places where by module we meant "checker" that might as well be clear about that. Do you want to open an issue for fixing the rest of the docs?

cve_bin_tool/checkers/libjpeg.py Outdated Show resolved Hide resolved
cve_bin_tool/OutputEngine.py Outdated Show resolved Hide resolved
SinghHrmn and others added 2 commits June 26, 2020 13:30
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
@SinghHrmn SinghHrmn requested a review from terriko June 26, 2020 08:01
@pdxjohnny pdxjohnny merged commit 3632e74 into intel:master Jun 30, 2020
@SinghHrmn SinghHrmn deleted the productName branch July 24, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants