Asynchronous extractor module #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert some changes
update
Until everything will get converted to async, we have to keep two flavors of functions sometime.
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 87.71% 79.69% -8.02%
==========================================
Files 76 76
Lines 2173 2241 +68
Branches 264 269 +5
==========================================
- Hits 1906 1786 -120
- Misses 208 390 +182
- Partials 59 65 +6
Continue to review full report at Codecov.
|
pdxjohnny
reviewed
Jun 9, 2020
cve_bin_tool/extractor.py
Outdated
| await aio_rmdir(self.tempdir) | ||
|
|
||
| def extract(self, filename): | ||
| aws = asyncio.gather(self.aio_extract(filename)) |
There was a problem hiding this comment.
I am using ensure_future now.
pdxjohnny
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have converted every I/O functions into async and I have also kept sync counterpart of some otherwise it will break CI. This sync function will eventually get removed once every module will become asynchronous.