Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codecov to Github Actions file #487

Merged
merged 15 commits into from
Mar 26, 2020
Merged

Conversation

Niraj-Kamdar
Copy link
Contributor

No description provided.

@Niraj-Kamdar Niraj-Kamdar changed the title changed yml file for integrate codecov in ubuntu Added codecov to Github Actions file Mar 20, 2020
@Niraj-Kamdar
Copy link
Contributor Author

Niraj-Kamdar commented Mar 20, 2020

successfully integrated codecov into github actions pipeline.
this will fix issue #288

@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #487 into master will increase coverage by 1.35%.
The diff coverage is 76.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   85.14%   86.50%   +1.35%     
==========================================
  Files          47       47              
  Lines        2026     2089      +63     
  Branches      412      418       +6     
==========================================
+ Hits         1725     1807      +82     
+ Misses        200      182      -18     
+ Partials      101      100       -1     
Flag Coverage Δ
#longtests 84.53% <75.36%> (?)
#ubuntutests 74.45% <75.36%> (?)
#wintests 45.45% <42.02%> (?)
Impacted Files Coverage Δ
cve_bin_tool/OutputEngine.py 58.62% <ø> (+0.99%) ⬆️
cve_bin_tool/checkers/__init__.py 100.00% <ø> (ø)
test/test_scanner.py 95.83% <ø> (+3.18%) ⬆️
cve_bin_tool/checkers/openssh.py 80.95% <20.00%> (-19.05%) ⬇️
cve_bin_tool/cli.py 87.97% <50.00%> (+5.33%) ⬆️
cve_bin_tool/extractor.py 73.26% <50.00%> (+2.74%) ⬆️
cve_bin_tool/checkers/gnutls.py 76.19% <58.33%> (-23.81%) ⬇️
cve_bin_tool/checkers/bzip2.py 73.68% <73.68%> (ø)
cve_bin_tool/csv2cve.py 87.23% <100.00%> (+0.56%) ⬆️
cve_bin_tool/cvedb.py 83.83% <100.00%> (-4.87%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518b55d...f4cefcd. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the right direction, but it says it's decreasing coverage by 35% so I believe it's not running something, or not combining coverage data correctly. I know I haven't run the coverage numbers since my work desktop went offline, but I don't think we should be seeing more than maybe a +/- 5% here. Can you figure out what's missing/not working?

@Niraj-Kamdar
Copy link
Contributor Author

It wasn't appending unittests initially. Now everything looks fine.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's give this a shot!

@terriko terriko merged commit 368c9b2 into intel:master Mar 26, 2020
@Niraj-Kamdar Niraj-Kamdar deleted the is-288 branch May 13, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants