-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added codecov to Github Actions file #487
Conversation
successfully integrated codecov into github actions pipeline. |
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 85.14% 86.50% +1.35%
==========================================
Files 47 47
Lines 2026 2089 +63
Branches 412 418 +6
==========================================
+ Hits 1725 1807 +82
+ Misses 200 182 -18
+ Partials 101 100 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the right direction, but it says it's decreasing coverage by 35% so I believe it's not running something, or not combining coverage data correctly. I know I haven't run the coverage numbers since my work desktop went offline, but I don't think we should be seeing more than maybe a +/- 5% here. Can you figure out what's missing/not working?
It wasn't appending unittests initially. Now everything looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's give this a shot!
No description provided.