Fixed:Broken checkers cause CI to hang indefinitely #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't really fix the issue -- the checkers still hang and that's not good even if we set shorter timeouts. Shorter timeouts isn't a bad idea in and of itself, though. Could you double all these numbers so that we're not very close to the expected time, just in case of transient network slowness? We've seen a fair bit of variability out of Github Actions and I don't want tests to fail if the network is just a little slow one day. |
|
What is happening?I just increased the number and the test is failing now. |
|
That is just weird. Github actions isn't even showing me any logs. |
|
The tests passed. |
|
Glad the tests started behaving. Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #449