Add test for output_csv in OutputEngine #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks tentatively good to me. @pdxjohnny if you've got more time to test today, give it a go? My work desktop is offline at the moment so I can't just pull it into my existing dev environment. |
|
I'll look into it 👍 |
pdxjohnny
approved these changes
Mar 11, 2020
|
Thanks @pdxjohnny ! |
|
Thank you @mariuszskon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly mentioned in #418, we should test the output produced by each method in OutputEngine. This PR tests the CSV output.
EDIT: closes #419