Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contains functionality in gnults.py #456

Merged
merged 8 commits into from
Mar 9, 2020
Merged

Add contains functionality in gnults.py #456

merged 8 commits into from
Mar 9, 2020

Conversation

SaurabhK122
Copy link
Contributor

@terriko
Copy link
Contributor

terriko commented Mar 9, 2020

Out of curiousity, was there a reason you changed the return in the "is" section?

@SaurabhK122
Copy link
Contributor Author

I found it easy to work with version_info as a dictionary, because while checking if version is not unknown we also need to know whether is_or_contains is null or not, that's why

@SaurabhK122 SaurabhK122 requested a review from terriko March 9, 2020 19:22
@terriko
Copy link
Contributor

terriko commented Mar 9, 2020

You don't actually need it for the is_or_contains check because you're returning if it "is" and the code below will never be reached, but I think you're right that it's nicer to read the way you've got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants