Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle unset serial number #4440

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: handle unset serial number #4440

merged 1 commit into from
Sep 13, 2024

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Sep 13, 2024

Signed-off-by: Terri Oda <terri.oda@intel.comm>
Copy link
Contributor

@mastersans mastersans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for overlooking this section. As far as I remember, the serial_number should be set to "" by default at most places, but I might have missed it somewhere. ; )

@terriko
Copy link
Contributor Author

terriko commented Sep 13, 2024

Yeah, easy mistake to make. I'm trying to figure out how to add a regression test for this but the coffee hasn't kicked in yet so I think I may open an issue instead.

@terriko terriko merged commit 5c3e103 into intel:main Sep 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: crash during triage output
2 participants