fix: modernize cvss score loading #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes intel#4370 Turns out our cvss score loading code was out of date and thus wasn't loading scores correctly and was throwing off a lot of log messages. Signed-off-by: Terri Oda <terri.oda@intel.com>
Signed-off-by: Terri Oda <terri.oda@intel.com>
|
Added some basic input validation on score/severity. The CVSS parsing library we're using will handle some input validation, but I'm doing some research to do some basic character filtering here before I declare this done. |
Signed-off-by: Terri Oda <terri@toybox.ca>
|
Character filtering done! I think this is ready for review. |
anthonyharrison
previously requested changes
Aug 28, 2024
|
@anthonyharrison I have done some more research and it turns out other than |
nedsouza
reviewed
Aug 28, 2024
nedsouza
approved these changes
Aug 29, 2024
terriko
dismissed
anthonyharrison’s stale review
score validation fixed as recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our cvss score loading code was out of date and thus wasn't loading scores correctly and was throwing off a lot of log messages.