Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Version not found error #431

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix Version not found error #431

merged 1 commit into from
Mar 2, 2020

Conversation

PrajwalM2212
Copy link
Contributor

@PrajwalM2212 PrajwalM2212 commented Mar 2, 2020

It was reported that running cve-bin-tool after running python3 setup.py install resulted in file not found error due to missing VERSION file.

@PrajwalM2212
Copy link
Contributor Author

There are 2 ways to solve this,

  1. package_data
  2. data_files (currently used method)

The package_data method only works if the VERSION file is inside the package cve_bin_tool, but VERSION currently resides in cve-bin-tool directory.

https://docs.python.org/3/distutils/setupscript.html#installing-additional-files

@terriko
Copy link
Contributor

terriko commented Mar 2, 2020

Is there a reason not to just move VERSION into cve_bin_tool with the rest? If that's the sort of standard packaging flow, maybe we should just move it. Unless there's a benefit to having it in the main directory?

@terriko
Copy link
Contributor

terriko commented Mar 2, 2020

Thoguht about this over lunch -- I think probably moving VERSION is the right longer-term solution, but since this bug is affecting people right now I'm going to merge this and then open an issue to move it later.

@terriko terriko merged commit f8f9f5e into intel:master Mar 2, 2020
@terriko terriko mentioned this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants