Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the -o flag to specify the filename #425

Merged
merged 6 commits into from
Mar 9, 2020

Conversation

mariuszskon
Copy link
Contributor

This PR builds upon #410 and uses the open source convention of the -o flag specifying the filename. This convention is used by many high profile open source projects, including, gcc, wget, and curl.

Since the -o flag was taken to specify the output format, I switched this with the -f flag (which prior to this PR specified the filename).

I have added documentation to reflect this.

@mariuszskon
Copy link
Contributor Author

Looks like some connections timed out during the tests, but it appears these are unrelated to my changes?

@terriko
Copy link
Contributor

terriko commented Mar 2, 2020

Hm, this is probably a good idea. I seem to have broken the PR in merging some of the other doc updates, but I'll try to come back to it once I'm done with my pass on the easier to merge PRs today.

cve_bin_tool/cli.py Outdated Show resolved Hide resolved
cve_bin_tool/cli.py Show resolved Hide resolved
@terriko terriko merged commit 6390766 into intel:master Mar 9, 2020
@mariuszskon
Copy link
Contributor Author

Thanks @terriko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants