Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved cpe parsing in sbom code #4082

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

ranjanmangla1
Copy link
Contributor

fixes #4073

Signed-off-by: ranjanmangla1 <ranjanmangla1@gmail.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've added suggestions for some comments because that regex is fairly hard for most casual observers to read.

cve_bin_tool/sbom_manager/__init__.py Show resolved Hide resolved
cve_bin_tool/sbom_manager/__init__.py Show resolved Hide resolved
@terriko
Copy link
Contributor

terriko commented Apr 25, 2024

The tests will re-run now, but unless I made a typo that breaks linting I expect I'll be back to approve and merge these once they're done!

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (d6cbe40) to head (9adee51).
Report is 191 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4082      +/-   ##
==========================================
+ Coverage   75.41%   81.30%   +5.89%     
==========================================
  Files         808      820      +12     
  Lines       11983    12533     +550     
  Branches     1598     1941     +343     
==========================================
+ Hits         9037    10190    +1153     
+ Misses       2593     1915     -678     
- Partials      353      428      +75     
Flag Coverage Δ
longtests 76.44% <100.00%> (+1.03%) ⬆️
win-longtests 79.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge now. Thank you again!

@terriko terriko merged commit 8bafaf5 into intel:main Apr 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: improve cpe parsing in sbom code
3 participants